Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit backend #3831

Merged
merged 30 commits into from
Jun 21, 2023
Merged

Audit backend #3831

merged 30 commits into from
Jun 21, 2023

Conversation

iliax
Copy link
Contributor

@iliax iliax commented May 16, 2023 •
edited by Haarolean
Loading

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)
Implements #2998

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@github-actions github-actions bot added the status/triage Issues pending maintainers triage label May 16, 2023
@iliax iliax changed the title WIP: Audit backent Audit backend May 22, 2023
@iliax iliax marked this pull request as ready for review May 22, 2023 20:03
@iliax iliax requested a review from a team as a code owner May 22, 2023 20:03
@iliax iliax requested a review from Haarolean May 22, 2023 20:06
iliax and others added 4 commits June 1, 2023 13:40
@iliax @AndreyNenashev
Update kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/A…
8a291ba 
…clsController.java

Co-authored-by: Andrey Nenashev <[email protected]>
@iliax
Merge branch 'master' into audit_be
a1ae46a
Merge branch 'master' of github.com:provectus/kafka-ui into audit_be
4b103cd 
� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/KafkaConnectController.java
audit properties added to config yaml
94a3c16
Haarolean
Haarolean suggested changes Jun 20, 2023
View reviewed changes
kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/BrokersController.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/ClustersController.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/model/rbac/AccessContext.java Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/KafkaConnectController.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/MessagesController.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/audit/AuditRecord.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/AdminClientService.java Outdated Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/BrokerService.java Outdated Show resolved Hide resolved
kafka-ui-contract/src/main/resources/swagger/kafka-ui-api.yaml Show resolved Hide resolved
kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/audit/AuditWriter.java Show resolved Hide resolved
@Haarolean Haarolean added scope/backend and removed status/triage Issues pending maintainers triage labels Jun 20, 2023
@Haarolean Haarolean linked an issue Jun 20, 2023 that may be closed by this pull request
Audit History #2998
Closed
iliax added 8 commits June 20, 2023 11:39
PR review fixes, minor improvements
d968125
PR review fixes, minor improvements
885d2b4
PR review fixes, minor improvements
12efde1
PR review fixes, minor improvements
b571b12
Merge branch 'master' of github.com:provectus/kafka-ui into audit_be
e8b9bf7 
� Conflicts:
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/controller/TopicsController.java
�	kafka-ui-api/src/main/java/com/provectus/kafka/ui/service/rbac/AccessControlService.java
�	kafka-ui-api/src/test/java/com/provectus/kafka/ui/util/AccessControlServiceMock.java
PR review fixes, minor improvements
b98e763
PR review fixes, minor improvements
e770bfb
checkstyle fix
a5084c3
@iliax iliax requested a review from Haarolean June 20, 2023 09:37
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@iliax iliax merged commit c743067 into master Jun 21, 2023
@iliax iliax deleted the audit_be branch June 21, 2023 08:02
@iliax iliax mentioned this pull request Jul 27, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreyNenashev AndreyNenashev AndreyNenashev left review comments

@Haarolean Haarolean Haarolean approved these changes

Assignees
No one assigned
Labels
area/audit scope/backend type/feature A new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Audit History
3 participants
@iliax @Haarolean @AndreyNenashev