Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Messages Paging #3955

Closed

Conversation

maros2710
Copy link

What changes did you make? (Give an overview)
I have fixed paging in messages as it was not working (described here: #3129)
'page' query param was not sent to controller, acording to this parameter, i just move offset of the topic.

Is there anything you'd like reviewers to focus on?
Just check if it is ok :)

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)
image

@maros2710 maros2710 requested a review from a team as a code owner June 20, 2023 07:51
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there maros2710! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@sonarcloud
Copy link

sonarcloud bot commented Jun 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@Haarolean
Copy link
Contributor

Hi,

unfortunately, we're not accepting any new commits related to the messages API at this time. We have plans to reimplement the messages API within task #3504, and attempting to address the issues here would likely add further complexity on the frontend, potentially causing more problems than it solves.

We truly appreciate your effort and understanding. Please feel free to contribute to other issues.

Thank you once again for your contribution!

@Haarolean Haarolean closed this Jun 20, 2023
@maros2710
Copy link
Author

Okay i see, no worries, thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants