Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw obvious exception in case no oauth2 providers have been defined #4002

Merged
merged 2 commits into from
Aug 2, 2023

Conversation

Haarolean
Copy link
Contributor

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@Haarolean Haarolean added scope/backend type/chore Boring stuff, could be refactoring or tech debt labels Jul 3, 2023
@Haarolean Haarolean added this to the 0.8 milestone Jul 3, 2023
@Haarolean Haarolean requested a review from a team as a code owner July 3, 2023 12:00
@Haarolean Haarolean self-assigned this Jul 3, 2023
# Conflicts:
#	kafka-ui-api/src/main/java/com/provectus/kafka/ui/config/auth/OAuthSecurityConfig.java
@Haarolean Haarolean enabled auto-merge (squash) August 2, 2023 12:47
@Haarolean Haarolean merged commit 6a40146 into master Aug 2, 2023
8 checks passed
@Haarolean Haarolean deleted the chore/oauth-warn branch August 2, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope/backend type/chore Boring stuff, could be refactoring or tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants