add schema validation support for more json-schema version refs (closes #2354) #4390
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes did you make?
Issue #2354 mentions that attempting to publish a message with schema validation will fail using a schema that references json-schema version draft-07. According to the Ajv docs, different json-schema versions (as referenced by the
$schema
property) require using different modules in Ajv. The current code always uses the draft-2020-12 module, which will throw errors if an earlier version of json-schema is referenced in the$schema
property--so I added some code that will select the correct Ajv module based on the$schema
property.Is there anything you'd like reviewers to focus on?
This is my very first open-source contribution--please be gentle! :)
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
As requested--my favorite dog breed :)