Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'aws-msk-iam-auth' version #4438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

daniel-farkas-glbe
Copy link

@daniel-farkas-glbe daniel-farkas-glbe commented Apr 29, 2024

Update 'aws-msk-iam-auth version' so it will support SSO auth

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

  • Update 'aws-msk-iam-auth version' so it will support SSO auth

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary) Check that I was able to login to the Kafka Cluster using AWS SSO profile
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

Update 'aws-msk-iam-auth version' so it will support SSO auth
@daniel-farkas-glbe daniel-farkas-glbe requested a review from a team as a code owner April 29, 2024 10:38
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there daniel-farkas-glbe! 👋

Thank you and congrats 🎉 for opening your first PR on this project! ✨ 💖

We will try to review it soon!

@Haarolean
Copy link
Contributor

@daniel-farkas-glbe this repo is not maintained (#4255), would be happy to see your PRs here: https://github.com/kafbat/kafka-ui (IIRC we've already done that there)

@matan129 matan129 mentioned this pull request Jun 4, 2024
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants