-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow arbitrary bytes as upstream name of grpc call #124
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Signed-off-by: Michał Krasnoborski <[email protected]>
c9f2f37
to
b0c311e
Compare
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
IMHO, the ability to declare upstreams in Envoy's implementation was a mistake and should be removed (but that's a bit tricky, since Istio Telemetry plugins are using it), since it breaks sandboxing in a pretty fundamental way. Is there any specific reason why you want/need this feature? |
Envoy allows the upstream to be serialized GrpcService message, but the proxy-wasm API allows only
&str
. (why use GrpcService message – to be able to connect to arbitrary upstream not predefined in envoy's clusters). This functionality seems to be supported by envoy so it makes sense to expose it in SDK.This is obviously a breaking change, not sure how to make it non-breaking though (I thought about
impl AsRef<u8>
, but that would break object safety, I guess. Perhaps a separate trait method would a better solution?)I've also looked a bit in the spec, in which the
upstream
argument is calledgrpc_service
(hinting the use of formentioned GrpcService message), but in your PR, this argument is called justupstream_name
. So thus I'm confused on the state of that feature, can you shed some light there?