Add explicit context_id parameter to all hostcalls.
#92
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While there, add and consistently use `UNKNOWN_RESOURCE_ID` error for when resources are accessed using an unknown ID. Signed-off-by: Piotr Sikora <[email protected]>
PiotrSikora
commented
Sep 25, 2025
Comment on lines
235
to
243
| * returns: | ||
| - `i32 (`[`proxy_status_t`]`) status` | ||
|
|
||
| > **Warning** | ||
| > This function has been deprecated in favor of explicit context IDs. | ||
| Changes the effective context to `context_id`. | ||
|
|
||
| This can be used to change active context, e.g. during |
There was a problem hiding this comment.
Perhaps it should be completely removed?
PiotrSikora
commented
Sep 25, 2025
|
|
||
| | Identifier | Name | Values | Deprecated | | ||
| |:----------:|:--------------------------------|:---------------------------------------------------------------------------------------------------|:----------:| | ||
| | 0x1001 | `HOST_TRACKS_ACTIVE_CONTEXT_ID` | When `1`, `context_id` can be set to `0`, which then indicates host-tracked active context ID. | Yes | |
There was a problem hiding this comment.
I originally envisioned this as a helpful step to ease the migration (i.e. SDKs could simply pass 0 as context_id and rely on hosts doing the tracking), but I'm not sure if that's worth it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While there, add and consistently use
UNKNOWN_RESOURCE_IDerrorfor when resources are accessed using an unknown ID.