Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for backfill service with disabled backfill #15058

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

GarmashAlex
Copy link

@GarmashAlex GarmashAlex commented Mar 16, 2025

What type of PR is this?

Bug fix

What does this PR do? Why is it needed?

This PR fixes linter errors in the beacon-chain/sync/backfill/service_test.go file. The linter was reporting two errors:

  1. undefined: require.False
  2. srv.isBackfilling undefined (type *Service has no field or method isBackfilling)
    The PR adds a test case to verify the behavior of the backfill service when backfill is explicitly disabled. The test ensures that the service properly respects the disabled configuration and does not attempt to perform backfill operations.

Which issues(s) does this PR fix?

Fixes linter errors in the backfill service test file.

Other notes for review

The test adds proper verification of the backfill service's state when backfill is disabled, which was missing from the test suite.

Acknowledgements

@GarmashAlex GarmashAlex requested a review from a team as a code owner March 16, 2025 13:16
@GarmashAlex GarmashAlex requested review from kasey, nalepae and nisdas March 16, 2025 13:16
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants