refactor state-by-root tests to table-driven #15087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasey
force-pushed
the
stategen-test-refactor
branch
2 times, most recently
from
6e2e54d to
4c96a6a
Compare
kasey
force-pushed
the
stategen-test-refactor
branch
from
4c96a6a to
bf002fb
Compare
terencechain
approved these changes
Mar 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
The previous tests were not covering the state by root methods well. Several of the replay tests were not actually causing blocks to be loaded from the database. This PR consolidates a number of tests into table-driven tests that work in a more consistent way and reuse helpers to make it more clear how each test case differs.
Acknowledgements