Allow hex strings in /eth/v1/beacon/states/{state_id}/root endpoint
#15098
+48
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkapka
force-pushed
the
fix-state-root-endpoint
branch
from
31cf281 to
77eb34a
Compare
james-prysm
reviewed
Mar 26, 2025
beacon-chain/rpc/lookup/stater.go
Outdated
| @@ -185,7 +185,15 @@ func (p *BeaconDbStater) StateRoot(ctx context.Context, stateId []byte) (root [] | |||
| case "justified": | |||
| root, err = p.justifiedStateRoot(ctx) | |||
| default: | |||
| if len(stateId) == 32 { | |||
| if len(stateIdString) >= 2 && stateIdString[:2] == "0x" { | |||
There was a problem hiding this comment.
what about using byteutil.IsHex([]byte(stateIdString))
james-prysm
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
BeaconDbStater.StateRootis missing the option to parse hex strings. This causes errors when passing a hex string in thestate_idparam of/eth/v1/beacon/states/{state_id}/rootWhich issues(s) does this PR fix?
Fixes #15049
Acknowledgements