Fix the return order of AsyncHTMLSession.run #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #480
Stack Overflow question: AsyncHTMLSession returns responses list disorderly! How to sort or make list ordered?
done
is aset
, which is unordered.Since
AsyncHTMLSession.run
callsrun_until_complete(...)
, alltasks
are indone
, so we can just iteratetasks
.This change is backward-compatible.
done
is not in the order of completion, unlikeasyncio.as_completed
, so there is no loss of information in this change.From https://github.com/python/cpython/blob/4cc63e0/Lib/asyncio/tasks.py#L535-L541:
where
fs = set(tasks)
.