Fix: Wrap unhandled urllib3 HTTPError types in RequestException #7060
+46
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances error handling in
HTTPAdapterto properly wrap unhandled urllib3HTTPErrorexceptions inRequestException, ensuring consistent exception handling across the requests library.Problem
Previously, when urllib3 raised an
HTTPErrorthat wasn't explicitly handled (i.e., notSSLError,ReadTimeoutError, orInvalidHeader), the exception would propagate as-is. This created inconsistent error handling behavior where some urllib3 exceptions would bypass the requests exception hierarchy.Solution
Modified
src/requests/adapters.py:send()method to wrap unknownHTTPErrortypes inRequestExceptionfrom errto all raised exceptions for better debugging and traceback clarityetoerrfor improved code readabilityAdded comprehensive test coverage in
tests/test_adapters.py:test_unknown_httperror_wrapped_in_requestexception()to verify that generic urllib3 HTTPError exceptions are properly wrappedRequestException__cause__Changes
Technical Details
from errTesting
✅ New unit test added and passing
✅ Verifies proper exception wrapping behavior
✅ Confirms exception chaining integrity
✅ Validates request object attachment