Skip to content

Fix test compatibility on Windows by using direct CA certificate path #7063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

Fix test compatibility on Windows by using direct CA certificate path #7063

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion tests/test_requests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2961,7 +2961,11 @@ def response_handler(sock):
r1 = s.get(url, verify=False)
assert r1.status_code == 200

r2 = s.get(url, verify="tests/certs/valid/ca/ca.crt")
# Use expired/ca/ca.crt directly for cross-platform compatibility.
# tests/certs/valid/ca is a symlink to ../expired/ca which doesn't
# work reliably on Windows without a specific Git configuration.
# The valid server cert is signed by the expired CA, so this path is correct.
r2 = s.get(url, verify="tests/certs/expired/ca/ca.crt")
assert r2.status_code == 200

close_server.set()
Expand Down