Skip to content

Conversation

@kopepasah
Copy link

Adds the ability to install this plugin via composer.

@psignoret
Copy link
Owner

Thanks for this pull request! Do you forsee any issues with the fact that I've taken firebase/php-jwt (under lib/php-jwt), prefixed the original namespace with "AADSSO/", but left it's original composer.json file in there?

@bradkovach
Copy link
Contributor

bradkovach commented Nov 1, 2018 via email

@kopepasah
Copy link
Author

This change would not impact how firebase/php-jwt is currently included. If you wanted to later include firebase/php-jwt as a Composer dependency, you would need to first require it (composer require firebase/php-jwt) and rework the application a bit to allow the autoloader to include those files.

As far as this change is concerned, it just allows installing this plugin as a Composer dependency (otherwise we have to create a fork, add our own composer.json and then require as a dependency - as I did here)

@kopepasah
Copy link
Author

@psignoret was there any additional information you required?

@paulgibbs
Copy link

@psignoret Will you merge this PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants