fix: resolve forward references in DI container and Router#47
Merged
Conversation
Fix NameError when DI container and Router encounter forward reference type annotations that aren't resolvable in the current namespace. This occurs when types are imported locally (inside configure() methods) or under TYPE_CHECKING blocks with `from __future__ import annotations`. The container now builds a namespace including all registered types before calling get_type_hints(), and the Router gracefully falls back to raw annotations when forward references can't be resolved. Fixes forward reference error with PasswordHasher in myfy-user where UserModule couldn't initialize due to forward reference resolution failures. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
- Remove commented-out import examples that triggered ERA001 (ruff) - Add type: ignore[unresolved-reference] for intentionally undefined types in forward reference tests (ty) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix NameError when DI container and Router encounter forward reference type annotations that aren't resolvable in the current namespace. This occurs when types are imported locally (inside configure() methods) or under TYPE_CHECKING blocks.
Changes
Testing
All 484 tests pass across myfy-core, myfy-web, and myfy-user packages.
🤖 Generated with Claude Code