Skip to content

Commit

Permalink
Set "grdtnFlg" to "Y" once final submission is approved (#840)
Browse files Browse the repository at this point in the history
* grdtnFlg set when final submission is approved.

* Fixed issues

* Fixed test it block
  • Loading branch information
ajkiessl committed Sep 11, 2024
1 parent 4fefbde commit c492716
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 5 deletions.
6 changes: 3 additions & 3 deletions app/models/lionpath/lionpath_export_payload.rb
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ def json_payload
"candAdvFlg" => core_committee_approved,
"exPymtFlg" => payment_received,
"libDepFlg" => federal_funding_used,
"grdtnFlg" => program_head_approved
"grdtnFlg" => final_submission_approved
}.each do |key, value|
internal_data[key] = value if value
end
Expand Down Expand Up @@ -53,8 +53,8 @@ def embargo_type
access_level_map[submission.access_level]
end

def program_head_approved
return "Y" if status_behavior.beyond_waiting_for_committee_review_rejected?
def final_submission_approved
return "Y" if status_behavior.beyond_waiting_for_final_submission_response_rejected?

nil
end
Expand Down
16 changes: 14 additions & 2 deletions spec/models/lionpath/lionpath_export_payload_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
allow(status_behavior).to receive(:beyond_waiting_for_committee_review?).and_return(false)
allow(status_behavior).to receive(:beyond_waiting_for_final_submission_response?).and_return(false)
allow(status_behavior).to receive(:beyond_waiting_for_committee_review_rejected?).and_return(false)
allow(status_behavior).to receive(:beyond_waiting_for_final_submission_response_rejected?).and_return(false)
end

it 'returns JSON formatted object' do
Expand Down Expand Up @@ -72,9 +73,9 @@
allow(status_behavior).to receive(:beyond_waiting_for_committee_review_rejected?).and_return(true)
end

it 'sets grdtnFlg to Y' do
it 'sets grdtnFlg to nil' do
payload = JSON.parse(export_payload.json_payload)
expect(payload["PE_SR199_ETD_REQ"]["grdtnFlg"]).to eq("Y")
expect(payload["PE_SR199_ETD_REQ"]["grdtnFlg"]).to eq(nil)
end

context 'when federal funding is true' do
Expand Down Expand Up @@ -129,6 +130,17 @@
end
end

context 'when thesis is beyond_waiting_for_final_submission_response_rejected' do
before do
allow(status_behavior).to receive(:beyond_waiting_for_final_submission_response_rejected?).and_return(true)
end

it 'sets grdtnFlg to Y' do
payload = JSON.parse(export_payload.json_payload)
expect(payload["PE_SR199_ETD_REQ"]["grdtnFlg"]).to eq('Y')
end
end

context 'when access_level is open_access' do
it 'sets embargoType to OPEN' do
payload = JSON.parse(export_payload.json_payload)
Expand Down

0 comments on commit c492716

Please sign in to comment.