Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Mute sounds" menu item #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

stevenleeg
Copy link

Screenshot

What?
I basically just added a menu item that allows for users to quickly mute Limechat's sound notifications.

Why?
Sometimes I want to know what everyone is saying in a channel and other times I want everyone to shut the f*** up already! This seemed to be a nice in-between feature 😃

Notes
This is my first pull request for an Objective-C project, so I apologize in advance if my code is a bit rusty. I tried to stick with the coding style of the project, but if I messed anything up let me know and I'll get it fixed. Limechat seems to have a really well formatted codebase, so I don't want to be the one to ruin that!

I also think I changed a bit too much in MainMenu.nib (version control with these files is terrible, ugh), so let me know what needs to be changed there.

Feedback would be super appreciated and I hope you guys like this!

@windley
Copy link

windley commented May 15, 2014

Why isn't this in Limechat. It's exactly what I need.

@stevenleeg
Copy link
Author

I wish it would get merged in :(

dburkart added a commit to dburkart/limechat that referenced this pull request Sep 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants