-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the QnA in a panel #202
base: main
Are you sure you want to change the base?
Conversation
Hi @shubhangi013, can you add before and after images/gif of the UI change? Thanks! |
index.html
Outdated
</div> | ||
<div class="modal-footer"> | ||
<a data-dismiss="modal" data-toggle="modal" class="btn">cancel</a> | ||
</div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhangi013 I don't think you've disabled your linter/formatter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhangi013 I don't think you've disabled your linter/formatter.
I think it's not because of the linter...because that I've disabled but, because of indentation difference in my IDE. and here are the after and before results :
Before:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhangi013 Did you undo the changes your linter added before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shubhangi013 Did you undo the changes your linter added before?
I disabled linter and prettier, cloned the repository again, then checked out to a new branch and did the changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually the linter/formatter is the problem in this case but since you've disabled it, I'm not sure what the issue is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if the issue helps github/VisualStudio#1524 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See if the issue helps github/VisualStudio#1524 (comment)
Yes! Thank you. I'll look at it. It seems to be an indentation problem 😅
Signed-off-by: shubhangi013 <[email protected]>
@TildaDares I have tried resolving this. I believe if it's just an indentation issue, which it most probably is, it'll be resolved by once setting the indentation in the repository code itself. 😃 |
@shubhangi013 I don't think setting the indentation on the repo itself will solve the problem. Have you considered using gitpod for your development? It's almost the same as using your local env. |
My system would give in if I install another IDE 😅 I'll try Vscode extension. |
Signed-off-by: shubhangi013 <[email protected]>
Signed-off-by: shubhangi013 <[email protected]>
@shubhangi013 Gitpod is a remote development platform https://publiclab.github.io/infragram/ You don’t have to install anything. |
@TildaDares I think it's finally done. Could you have a look? |
fixes #197