Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the QnA in a panel #202

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

shubhangi013
Copy link
Contributor

fixes #197

@gitpod-io
Copy link

gitpod-io bot commented Mar 3, 2022

@TildaDares
Copy link
Member

Hi @shubhangi013, can you add before and after images/gif of the UI change? Thanks!

index.html Outdated
</div>
<div class="modal-footer">
<a data-dismiss="modal" data-toggle="modal" class="btn">cancel</a>
</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhangi013 I don't think you've disabled your linter/formatter.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhangi013 I don't think you've disabled your linter/formatter.

I think it's not because of the linter...because that I've disabled but, because of indentation difference in my IDE. and here are the after and before results :
Before:
Screenshot from 2022-03-03 21-39-38
Screenshot from 2022-03-03 21-39-24

After:
Screenshot from 2022-03-03 21-34-51
Screenshot from 2022-03-03 21-34-01

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhangi013 Did you undo the changes your linter added before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shubhangi013 Did you undo the changes your linter added before?

I disabled linter and prettier, cloned the repository again, then checked out to a new branch and did the changes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually the linter/formatter is the problem in this case but since you've disabled it, I'm not sure what the issue is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if the issue helps github/VisualStudio#1524 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See if the issue helps github/VisualStudio#1524 (comment)

Yes! Thank you. I'll look at it. It seems to be an indentation problem 😅

@shubhangi013
Copy link
Contributor Author

@TildaDares I have tried resolving this. I believe if it's just an indentation issue, which it most probably is, it'll be resolved by once setting the indentation in the repository code itself. 😃

@TildaDares
Copy link
Member

@shubhangi013 I don't think setting the indentation on the repo itself will solve the problem. Have you considered using gitpod for your development? It's almost the same as using your local env.

@shubhangi013
Copy link
Contributor Author

@shubhangi013 I don't think setting the indentation on the repo itself will solve the problem. Have you considered using gitpod for your development? It's almost the same as using your local env.

My system would give in if I install another IDE 😅 I'll try Vscode extension.
I'll try again after a few mins to resolve the indentation error.

@TildaDares
Copy link
Member

@shubhangi013 Gitpod is a remote development platform https://publiclab.github.io/infragram/

You don’t have to install anything.

@shubhangi013
Copy link
Contributor Author

@TildaDares I think it's finally done. Could you have a look?

@TildaDares TildaDares added the on-hold There is a temporary hold on any continued work or review. label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on-hold There is a temporary hold on any continued work or review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Q&A are clustered
2 participants