improve ui #51
Open
improve ui #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jywarren @gauravano please review |
VladimirMikulic
suggested changes
Jan 10, 2020
jywarren
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
@VladimirMikulic should we merge this now and continue in a follow-up? Thank you for sharing screenshots, i didn't have a chance to do a close review here. Thank you @avsingh999 for your patience as well!
VladimirMikulic
approved these changes
Jan 16, 2020
There was a problem hiding this comment.
@jywarren we can merge this now and create an FTO for adding padding to the footer.
|
OK, i like it! Hmm, though, the conflicts are a bit much for me to go through right now. @avsingh999 if you are still interested, I'd love a bit of help with resolving conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #7
