Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 9, 2022

Bumps sentry-ruby from 5.1.1 to 5.2.0.

Changelog

Sourced from sentry-ruby's changelog.

5.2.0

Features

  • Log Redis command arguments when sending PII is enabled #1726

  • Add request env to sampling context #1749

    Example

    Sentry.init do |config|
      config.traces_sampler = lambda do |sampling_context|
        env = sampling_context[:env]
    if env["REQUEST_METHOD"] == "GET"
      0.01
    else
      0.1
    end
    
    end
    end

  • Check envelope size before sending it #1747

    The SDK will now check if the envelope's event items are oversized before sending the envelope. It goes like this:

    1. If an event is oversized (200kb), the SDK will remove its breadcrumbs (which in our experience is the most common cause).
    2. If the event size now falls within the limit, it'll be sent.
    3. Otherwise, the event will be thrown away. The SDK will also log a debug message about the event's attributes size (in bytes) breakdown. For example,
    {event_id: 34, level: 7, timestamp: 22, environment: 13, server_name: 14, modules: 935, message: 5, user: 2, tags: 2, contexts: 820791, extra: 2, fingerprint: 2, platform: 6, sdk: 40, threads: 51690}
    

    This will help users report size-related issues in the future.

  • Automatic session tracking #1715

    Example:

    The SDK now supports automatic session tracking / release health by default in Rack based applications.
    Aggregate statistics on successful / errored requests are collected and sent to the server every minute.
    To use this feature, make sure the SDK can detect your app's release. Or you have set it with:

    Sentry.init do |config|

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added dependencies Pull requests that update a dependency file Ruby labels Mar 9, 2022
@gitpod-io
Copy link

gitpod-io bot commented Mar 9, 2022

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5595683807/artifacts/181577022

@jywarren
Copy link
Member

@dependabot rebase

@dependabot dependabot bot force-pushed the dependabot/bundler/sentry-ruby-5.2.0 branch from 8e78e64 to 533a866 Compare March 15, 2022 18:02
Bumps [sentry-ruby](https://github.com/getsentry/sentry-ruby) from 5.1.1 to 5.2.0.
- [Release notes](https://github.com/getsentry/sentry-ruby/releases)
- [Changelog](https://github.com/getsentry/sentry-ruby/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-ruby@5.1.1...5.2.0)

---
updated-dependencies:
- dependency-name: sentry-ruby
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/bundler/sentry-ruby-5.2.0 branch from 533a866 to a84aacd Compare March 15, 2022 18:03
@jywarren
Copy link
Member

@dependabot rebase

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 15, 2022

Looks like this PR is already up-to-date with main! If you'd still like to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jywarren
Copy link
Member

jywarren commented Mar 15, 2022

This is failing due to:

yarn check v1.22.17
warning Pattern ["grow-textarea@git+https://github.com/jywarren/grow.git#d[5](https://github.com/publiclab/plots2/runs/5558655426?check_suite_focus=true#step:5:5)4141c9456343f14cc6c935faa0915af09eb669"] is trying to unpack in the same destination "/home/runner/.cache/yarn/v6/npm-grow-textarea-1.0.1-d54141c9456343f14cc6c935faa0915af09eb669/node_modules/grow-textarea" as pattern ["grow-textarea@git://github.com/jywarren/grow.git#d54141c9456343f14cc6c935faa0915af09eb669"]. This could result in non-deterministic behavior, skipping.
error Command failed.
info Visit https://yarnpkg.com/en/docs/cli/check for documentation about this command.
Exit code: 128
Command: git
Arguments: ls-remote --tags --heads git://github.com/jywarren/grow.git
Directory: /home/runner/work/plots2/plots2
Output:
fatal: remote error: 
  The unauthenticated git protocol on port 9418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
yarn install v1.22.17
[1/4] Resolving packages...
[2/4] Fetching packages...
warning Pattern ["grow-textarea@git+https://github.com/jywarren/grow.git#d54141c9456343f14cc6c935faa0915af09eb669"] is trying to unpack in the same destination "/home/runner/.cache/yarn/v[6](https://github.com/publiclab/plots2/runs/5558655426?check_suite_focus=true#step:5:6)/npm-grow-textarea-1.0.1-d54141c9456343f14cc6c935faa0915af09eb669/node_modules/grow-textarea" as pattern ["grow-textarea@git://github.com/jywarren/grow.git#d54141c9456343f14cc6c935faa0915af09eb669"]. This could result in non-deterministic behavior, skipping.
error Command failed.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
Exit code: 12[8](https://github.com/publiclab/plots2/runs/5558655426?check_suite_focus=true#step:5:8)
Command: git
Arguments: ls-remote --tags --heads git://github.com/jywarren/grow.git
Directory: /home/runner/work/plots2/plots2
Output:
fatal: remote error: 
  The unauthenticated git protocol on port [9](https://github.com/publiclab/plots2/runs/5558655426?check_suite_focus=true#step:5:9)418 is no longer supported.
Please see https://github.blog/2021-09-01-improving-git-protocol-security-github/ for more information.
Error: Process completed with exit code [12](https://github.com/publiclab/plots2/runs/5558655426?check_suite_focus=true#step:5:12)8.

Key area:

warning Pattern ["grow-textarea@git+https://github.com/jywarren/grow.git#d54141c9456343f14cc6c935faa0915af09eb669"] is trying to unpack in the same destination "/home/runner/.cache/yarn/v[6](https://github.com/publiclab/plots2/runs/5558655426?check_suite_focus=true#step:5:6)/npm-grow-textarea-1.0.1-d54141c9456343f14cc6c935faa0915af09eb669/node_modules/grow-textarea" as pattern ["grow-textarea@git://github.com/jywarren/grow.git#d54141c9456343f14cc6c935faa0915af09eb669"]. This could result in non-deterministic behavior, skipping.

We likely need to remove the reference in the old PublicLab.Editor entry in yarn.lock using protocol git://, or change it to https://.(https://stackoverflow.com/questions/70663523/the-unauthenticated-git-protocol-on-port-9418-is-no-longer-supported)

https://stackoverflow.com/questions/54875055/multiple-versions-of-the-same-package-in-the-yarn-lock-file

https://medium.com/@scinos/de-duplicating-yarn-lock-ae30be4aa41a

as it's already been fixed upstream: https://github.com/publiclab/PublicLab.Editor/blob/f75ed447f4290f2579c136a3e2b2cf70e5fb2eb8/package.json#L43

@qlty-cloud-legacy
Copy link

Code Climate has analyzed commit 4114404 and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #10768 (4114404) into main (c9fda7e) will increase coverage by 8.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #10768      +/-   ##
==========================================
+ Coverage   74.17%   82.45%   +8.27%     
==========================================
  Files          98       98              
  Lines        6115     5990     -125     
==========================================
+ Hits         4536     4939     +403     
+ Misses       1579     1051     -528     
Impacted Files Coverage Δ
app/models/tag.rb 93.23% <0.00%> (+0.48%) ⬆️
app/models/node.rb 91.27% <0.00%> (+0.67%) ⬆️
app/controllers/spam2_controller.rb 71.84% <0.00%> (+0.97%) ⬆️
app/controllers/user_tags_controller.rb 83.78% <0.00%> (+1.35%) ⬆️
app/models/user.rb 86.12% <0.00%> (+1.77%) ⬆️
app/controllers/search_controller.rb 97.67% <0.00%> (+2.32%) ⬆️
app/controllers/user_sessions_controller.rb 67.48% <0.00%> (+2.45%) ⬆️
app/models/image.rb 82.05% <0.00%> (+2.56%) ⬆️
app/helpers/application_helper.rb 88.65% <0.00%> (+3.09%) ⬆️
app/models/concerns/statistics.rb 100.00% <0.00%> (+3.27%) ⬆️
... and 23 more

@github-actions
Copy link

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here:
https://github.com/publiclab/plots2/suites/5671246562/artifacts/186098796

@jywarren jywarren merged commit ba02eba into main Mar 15, 2022
@dependabot dependabot bot deleted the dependabot/bundler/sentry-ruby-5.2.0 branch March 15, 2022 19:03
@jywarren
Copy link
Member

This isn't 100% done -- still seeing this sneaking back in. The root cause i think is https://github.com/publiclab/inline-markdown-editor which I'm updating and republishing to npm now without the publiclab-editor@^2.0.0 dependency... let's see!

@jywarren
Copy link
Member

@jywarren
Copy link
Member

jywarren commented Mar 18, 2022

Alternatively we could force protocol with

actions/setup-node#214 (comment)

git config --global url."https://github.com/".insteadOf ssh://[email protected]/

@jywarren
Copy link
Member

However I'm not seeing this error in other recent plots2 PRs... very strange. So maybe we can drop this for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file ready-for-review Ruby

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants