introduce void* parameter for user data in listeners
#207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavrax
requested review from
parfeon,
seba-aln and
KGronek-Pubnub
as code owners
parfeon
requested changes
Feb 20, 2025
Comment on lines
+268
to
+278
| pbcc_status_listener_t* pbcc_status_listener_alloc_( | ||
| pubnub_subscribe_status_callback_t callback, | ||
| void* user_data) | ||
| { | ||
| PBCC_ALLOCATE_TYPE(listener, pbcc_status_listener_t, true, NULL); | ||
| listener->callback = callback; | ||
| listener->user_data = user_data; | ||
|
|
||
| return listener; | ||
| } | ||
|
|
There was a problem hiding this comment.
Do we actually need this?
Can we go in other way and do the following:
- for
pubnub_subscribe_listener_typeaddPBSL_LISTENER_ON_STATUS - Modify
pbcc_event_listener_add_status_listenerandpbcc_event_listener_remove_status_listener?
Also we will probably will need to make a change to:
pbcc_initialize_array_(&listener->global_status, NULL))and add destructor call:
pbcc_initialize_array_(&listener->global_status, pbcc_listener_free_))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: introduce
void*parameter for user data in listenersIntroduce
void*parameter for user data in listeners to let callbacks keep context on demand.