Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit PNDisconnectedUnexpectedlyCategory #438

Merged
merged 2 commits into from
Feb 18, 2025
Merged

Emit PNDisconnectedUnexpectedlyCategory #438

merged 2 commits into from
Feb 18, 2025

Conversation

parfeon
Copy link
Contributor

@parfeon parfeon commented Feb 18, 2025

feat(subscribe): emit PNDisconnectedUnexpectedlyCategory

Emit 'PNDisconnectedUnexpectedlyCategory' in cases when client receives bad request or unexpected / malformed service response.

refactor(request): move deserialized error parse into abstract request

Move error / malformed response handling into AbstractRequest to simplify actual endpoint classes.

Emit 'PNDisconnectedUnexpectedlyCategory'  in cases when client receives bad request or
unexpected / malformed service response.

refactor(request): move deserialized error parse into abstract request

Move error / malformed response handling into `AbstractRequest` to simplify actual endpoint
classes.
@parfeon parfeon changed the title feat(subscribe): emit PNDisconnectedUnexpectedlyCategory Emit PNDisconnectedUnexpectedlyCategory Feb 18, 2025
@parfeon parfeon self-assigned this Feb 18, 2025
@parfeon parfeon added status: done This issue is considered resolved. priority: high This PR should be reviewed ASAP. type: feature This PR contains new feature. labels Feb 18, 2025
return __awaiter(this, void 0, void 0, function* () {
throw Error('Should be implemented by subclass.');
return this.deserializeResponse(response);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

*/
abort(): void {
if (this && this.cancellationController) this.cancellationController.abort();
abort(reason?: string): void {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@parfeon
Copy link
Contributor Author

parfeon commented Feb 18, 2025

@pubnub-release-bot release

@parfeon parfeon merged commit bd69c80 into master Feb 18, 2025
6 of 7 checks passed
@parfeon parfeon deleted the CLEN-2555 branch February 18, 2025 14:06
@pubnub-release-bot
Copy link
Contributor

🚀 Release successfully completed 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high This PR should be reviewed ASAP. status: done This issue is considered resolved. type: feature This PR contains new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants