Add ability to specify custom data in Push payloads #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcin-cebo
approved these changes
Feb 27, 2025
| @@ -280,6 +280,7 @@ abstract class BaseChannel<C : Channel, M : Message>( | |||
| quotedMessage: Message?, | |||
| files: List<InputFile>?, | |||
| usersToMention: Collection<String>?, | |||
| customPushData: Map<String, String>?, | |||
There was a problem hiding this comment.
General question to this feature. How would you test it?
There was a problem hiding this comment.
the push data is merged into the message content, so I would test that the message was sent (possibly with a mock of the publish PN SDK function) with the correct data in the correct place in the FCM and APNS payloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new optional parameter for
Channel.sendText-customPushData: Map<String,String>that lets users specify custom key values that will be put into the FCM message (indata) and/or APNS (in root object) that is sent with the message and also with every user mention.TODO: tests, JS wrapper