Calling .leave request when unsubscribing #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguz-pubnub
requested review from
parfeon,
wkal-pubnub and
marcin-cebo
as code owners
jguz-pubnub
changed the title
parfeon
approved these changes
Jun 17, 2024
| case .heartbeatSuccess: | ||
| return state is Presence.Heartbeating | ||
| case .heartbeatFailed: | ||
| return state is Presence.Heartbeating | ||
| case .timesUp: | ||
| return state is Presence.HeartbeatCooldown | ||
| case .leftAll: | ||
| return !(state is Presence.HeartbeatInactive) | ||
| return true |
There was a problem hiding this comment.
So, we want to transit even if heartbeat loop is not active?
There was a problem hiding this comment.
Yes. You're right, the heartbeat loop is inactive if the user subscribes to some channel without Presence. However, we still have to trigger .leave invocation as a part of the unsubscribe cleanup
|
@pubnub-release-bot release as 7.3.1 |
|
🚀 Release successfully completed 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(presence): calling .leave request in missing cases