Skip to content

fix: remove the behavior of de-select on second click#1575

Open
ojj1123 wants to merge 2 commits intopuckeditor:mainfrom
ojj1123:remove-deselect-behavior
Open

fix: remove the behavior of de-select on second click#1575
ojj1123 wants to merge 2 commits intopuckeditor:mainfrom
ojj1123:remove-deselect-behavior

Conversation

@ojj1123
Copy link

@ojj1123 ojj1123 commented Feb 20, 2026

close #1567

@vercel
Copy link

vercel bot commented Feb 20, 2026

@ojj1123 is attempting to deploy a commit to the Puck Team on Vercel.

A member of the Team first needs to authorize it.

@ojj1123 ojj1123 marked this pull request as draft February 20, 2026 05:21
@FedericoBonel
Copy link
Collaborator

Hey @ojj1123!

Thanks for taking a look at this, would you mind actually only adding the deselecting behavior if the _experimentalFullScreenCanvas is enabled?

This new mode was the main reason this behavior was introduced, so I think it makes sense to only enable it if that is true instead of fully getting rid of it.

Copy link
Collaborator

@FedericoBonel FedericoBonel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check above comment! 🙏

@ojj1123 ojj1123 marked this pull request as ready for review February 22, 2026 16:44
@ojj1123
Copy link
Author

ojj1123 commented Feb 22, 2026

would you mind actually only adding the deselecting behavior if the _experimentalFullScreenCanvas is enabled?

@FedericoBonel I changed it. Could you please review this PR?

Comment on lines +117 to +119
const {
_experimentalFullScreenCanvas
} = usePropsContext();
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DraggableComponent is rendered as a child element of the PropsProvider and so I used that context.

@Drewbiee123

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove "de-select component on second click" behavior

3 participants