fix: richtext inline focus problem with sync-editor#1577
Open
Xtron33 wants to merge 1 commit intopuckeditor:mainfrom
Open
fix: richtext inline focus problem with sync-editor#1577Xtron33 wants to merge 1 commit intopuckeditor:mainfrom
Xtron33 wants to merge 1 commit intopuckeditor:mainfrom
Conversation
|
Someone is attempting to deploy a commit to the Puck Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1557
Description
This PR remove overengineering logic from Editor for checking focus.
Changes made
nametouseSyncedEditorOld logic make problem with first
onChangecall when app think what focus on not-inline editor, but call useSyncedEditor from inline editor cause onChange not work.Using field-name for both work well.
How to test
Herocomponent.recording_2026-02-20_19.00.18.mp4