Skip to content

Document ridge_weights parameter in fit_sinusoidal_regression#47

Draft
Copilot wants to merge 3 commits into
masterfrom
copilot/sub-pr-45-again
Draft

Document ridge_weights parameter in fit_sinusoidal_regression#47
Copilot wants to merge 3 commits into
masterfrom
copilot/sub-pr-45-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 17, 2026

The ridge_weights parameter in fit_sinusoidal_regression was added in PR #45 but not documented in the function's docstring.

Changes

  • Added docstring entry for ridge_weights parameter explaining:
    • Accepts optional sequence of per-column regularization weights
    • Length must equal design matrix column count (including intercept if intercept=True)
    • Intercept column weight automatically set to 0.0 when intercept=True
def fit_sinusoidal_regression(
    X: np.ndarray,
    Y: np.ndarray,
    N_list: Sequence[int],
    ridge_weights: Optional[Sequence[float]] = None,  # Now documented
    ...
):
    """
    Parameters:
        ridge_weights: optional sequence of per-column regularization weights. Must have length
            equal to the number of design matrix columns (including the intercept column if
            intercept=True). When intercept=True, the intercept column weight is automatically
            set to 0.0 to avoid regularizing the intercept term.
    """

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: pukpr <2855758+pukpr@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on per-harmonic ridge_weights support implementation Document ridge_weights parameter in fit_sinusoidal_regression Jan 17, 2026
Copilot AI requested a review from pukpr January 17, 2026 17:25
Base automatically changed from codex/optimize-time-series-fitting-experiments to master January 17, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants