Moving ahead for finalizing working Session Handlers

[pulkit4tech]

Includes all recent changes i.e. -

• Deleting Timers using Celluloid#Timers=> which deletes value from outer hash automatically after expiry
• Updated Configuration logic and its usage
• Updated patching way for Parser to solve failing pipelined request test in connection_spec

Kindly Review 😃 /cc: @kenichi @digitalextremist

[kenichi]

o_O does that... work? @digitalextremist

[kenichi]

with the include Celluloid in store.rb below, this will cause a new actor/thread per request

[kenichi]

if i understand correctly, what you are trying to do here is have timers that "expire" the data from the hash store. you're trying to use the after(sec) &block method of a celluloid actor. so, to get that, with access to @key as well, you tried adding include Celluloid to the Store class.

unfortunately, as noted above, this makes each instance of the Store class an actor with its own thread. that's way too heavy per request.

one solution might be to create a single instance of a StoreExpiry class (that includes Celluloid) and register expiration there...

but why use another thread, when there's perfectly good reactor sitting around in the form of the reel server?

see the PR i just opened to get access to the server from inside requests. celluloid#228

[pulkit4tech]

Yes that would be heavy creating thread per request. Will be calling after on server instance using request .. Thanks @kenichi 😃

[kenichi]

regarding HeaderError, i don't think that's a good idea anymore, but see the other comments on #18 and #17 and lemme know your thoughts re: still setting the cookie even if the session is empty.

[pulkit4tech]

Merging 😃