Skip to content

Pass generic arguments to AsyncContentCache.make_response override - #2564

Merged
gerrod3 merged 1 commit into
pulp:mainfrom
pedro-psb:relax-override-signature
Oct 8, 2026
Merged

gerrod3 merged 1 commit into
pulp:mainfrom
pedro-psb:relax-override-signature

Conversation

@pedro-psb

@pedro-psb pedro-psb commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Pulpcore requires passing an extra argument to that method, but that breaks this override if it expects an exact set of arguments.

That causes this PR to be reverted and will enable having it back: pulp/pulpcore#8182

container 2.29 is the only supported branch that can be with pulpcore 3.121, which is expected to have that change in make_response.

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Pulpcore requires passing an extra argument to that method,
but that breaks this override if it expects an exact set of arguments.
@gerrod3
gerrod3 merged commit 3a61149 into pulp:main Oct 8, 2026
14 checks passed
@patchback

patchback Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Backport to 2.29: 💚 backport PR created

✅ Backport PR branch: patchback/backports/2.29/3a61149bd3c2c0558d1b18dc8e5e98cea74efcd3/pr-2564

Backported as #2565

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants