Skip to content

Fix deprecated license classifiers #838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix deprecated license classifiers #838

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized that this repository specifies requires = ["setuptools >= 40.8.0", "wheel >= 0.29.0"], but support for SPDX license expressions was added in setuptools v77.0.0 (https://setuptools.pypa.io/en/latest/history.html#v77-0-0), so my change is not compatible with the current build requirements, and will close this PR.

Out of curiosity, is there a chance we will be updating the build requirements in the near future?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh and v77.0.0 19 Mar 2025 is quite a bit recent.
Maybe if you had a chat with the build folks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will check with them in the next Integration scrum meeting and then decide on the next steps.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right now EL9 ships with 68.2 for python3.12, it's even older for 3.11.

Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ readme = "README.md"
authors = [
{name="Pulp Team", email="[email protected]"},
]
license = "GPL-2.0-or-later"
classifiers=[
"License :: OSI Approved :: GNU General Public License v2 or later (GPLv2+)",
"Operating System :: POSIX :: Linux",
"Development Status :: 5 - Production/Stable",
"Framework :: Django",
Expand Down