-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update "Chapter 2: Using Pulsar" documentation #59
Conversation
docs/docs/launch-manual/sections/using-pulsar/sections/atom-packages.md
Outdated
Show resolved
Hide resolved
@softcode589 I don't think you should approve draft PRs, this is only a placeholder at the moment to show that I'm working on this chapter and there are a hell of a lot of mistakes and problems still in the content. Most of the links don't work and I've not even run it on dev. |
The rest has been pushed, see the PR itself for the exact comments on this. |
As per the discord poll I've removed the emojis and replaced with three letter abbreviations (LNX/MAC/WIN). @kaosine could you resolve the outdated change request? |
docs/docs/launch-manual/sections/using-pulsar/sections/editing-and-deleting-text.md
Outdated
Show resolved
Hide resolved
docs/docs/launch-manual/sections/using-pulsar/sections/editing-and-deleting-text.md
Show resolved
Hide resolved
…-and-deleting-text.md Co-authored-by: Steven Nguyen <[email protected]>
…-and-deleting-text.md Co-authored-by: Steven Nguyen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good.
It's been open for quite some time without to much activity. Unless there's any final suggestions or issues to raise, I'll go ahead and merge in a bit.
As always thanks for your contributions, this was a big one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the commands in basic customization are already mindblowing enough that I feel the mindblown emoji ctrl+left, right change if made would be a separate pr
I was going to initially merge this, but somehow missed this before. The Test Deployment is failing on this PR. @Daeraxa would you be able to take a look at this? |
0abf11b
There was a dodgy link that I somehow missed and also didn't see the failing test for some reason. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing those issues. With my previous approval, and tests now passing lets merge!
Updating the "Using Pulsar" docs to remove Atom references etc and modify where necessary.
All the Atom Ch2 pages have now been added and should be working for our framework.
That means:
Atom
references rebranded asPulsar
atom
repo have been replaced withpulsar-edit
repoapm
andATOM_HOME
have been left and will be updated when these are done in coreOS correct FA6 icons once Child Theme and font awesome #62 is merged.as per Discord poll these are now replaced with LNX/MAC/WIN.Other comments
🐧/🪟<kbd>Ctrl+,</kbd> - 🍎<kbd>Cmd+,</kbd>
) which work better when occasionally referenced in larger sections and don't cause unnecessary duplication of text.This has all been tested on the main branch of this repo and works just fine in
dev
from what I can see but please try the links etc. in case I have missed anything or if there are any missing images due to bad references etc.