-
Notifications
You must be signed in to change notification settings - Fork 256
Add meta images to rss feed #16169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add meta images to rss feed #16169
Conversation
PR ReviewThanks for adding thumbnail support to the RSS feed! However, there are several issues that need to be addressed: Critical IssuesLine 2: Missing XML namespace declaration <rss version="2.0" xmlns:media="http://search.yahoo.com/mrss/"> Line 18: Incorrect URL construction <media:thumbnail url="{{ .Site.Params.canonicalURL }}{{ .RelPermalink }}{{ .Params.meta_image }}" /> This produces URLs like Other IssuesPR metadata
Testing RequiredBefore merging, please verify:
|
Your site preview for commit 49077e5 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16169-49077e50.s3-website.us-west-2.amazonaws.com. |
49077e5
to
23595b1
Compare
Your site preview for commit 23595b1 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16169-23595b1f.s3-website.us-west-2.amazonaws.com. |
23595b1
to
3157ac9
Compare
3157ac9
to
d516e1f
Compare
Your site preview for commit 3157ac9 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16169-3157ac90.s3-website.us-west-2.amazonaws.com. |
Your site preview for commit d516e1f is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16169-d516e1fd.s3-website.us-west-2.amazonaws.com. |
d516e1f
to
3091c75
Compare
Your site preview for commit 3091c75 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16169-3091c757.s3-website.us-west-2.amazonaws.com. |
Pull Request ReviewIssue FoundLine 18: Incorrect image URL construction The current implementation concatenates the canonical URL, the post's relative permalink, and the meta_image path. This creates an incorrect URL structure. For a blog post at /blog/my-post/ with meta_image: meta.png, the code generates: However, the meta_image parameter is typically just a filename (like meta.png) that lives alongside the index.md in a page bundle. The concatenation should work correctly since RelPermalink includes the trailing slash. Verification NeededPlease verify:
Technical Review
RecommendationThe implementation appears technically sound. The approach of embedding the image in the description using HTML is simpler and more compatible than media:content. Please test with your RSS reader to confirm the images display correctly before merging. |
Proposed changes
Add meta images to blog rss feed. I initially wanted to use media:content but somehow my rss feed reader didn't really like it so I think adding the image to the top of the description is simpler
Without adding the meta images, my feed reader was showing a random image from the article as the main image, which isn't as nice
Unreleased product version (optional)
Related issues (optional)