Updated Insights Page #16408
Updated Insights Page #16408
Conversation
kimberleyamackenzie
temporarily deployed
to
testing
GitHub Actions
Inactive
kimberleyamackenzie
temporarily deployed
to
testing
GitHub Actions
Inactive
Review of PR #16408: Updated Insights PageThank you for this comprehensive update to the Insights page. I've reviewed the changes and found several issues that need attention: Critical Issues1. Missing newline at end of fileFile: The file does not end with a newline. Per AGENTS.md, all files must end with a newline. Style Issues2. H2 heading capitalizationFile: "The Complete Governance Lifecycle" uses Title Case for an H2 heading. Per STYLE-GUIDE.md, H2 and deeper headings should use Sentence case. 3. H2 heading capitalizationFile: "Pre-Built Compliance Frameworks Ready to Deploy" uses Title Case. Should be Sentence case. 4. H2 heading capitalizationFile: "Analytics & Intelligence" uses Title Case. Should be Sentence case. 5. H2 heading capitalizationFile: "Pricing" could benefit from a more descriptive title, but if keeping it as-is, consider making it lowercase unless it's meant as a proper heading. 6. H2 heading capitalizationFile: "Take control of your cloud" - While this is Sentence case, the nested items have titles that may need review:
7. Lowercase "stack" usageFile: Per STYLE-GUIDE.md, use lowercase for non-proper nouns like "stack". Review the content to ensure consistent lowercase usage of common infrastructure terms. Content Issues8. Awkward phrasingFile: "Complete visibility and control for your cloud" is repeated twice - once in line 6 (subheading) and again in line 25 (overview header). Consider varying the language. 9. Missing articleFile: "Insights & Governance capabilities are included with Pulumi Cloud" - Consider adding "the" before "Pulumi Cloud" for better readability, or check if the existing phrasing matches brand guidelines. 10. Inconsistent terminologyFile: The document uses both "Policy as Code" (line 37) and "policy-as-code" (line 31) and "Policy-as-code" (line 72). Choose one consistent style and apply throughout. Per typical conventions, when used as a compound modifier, hyphenate it: "policy-as-code". When used as a title/proper reference, "Policy as Code" is appropriate. 11. Redundant phrasingFile: "Pulumi Neo's policy remediation capabilities and pre-built compliance frameworks." - This sentence fragment appears incomplete. It seems like part of a sentence was removed during editing. Template/HTML Issues12. Whitespace-only changes in header.htmlFile: The diff shows extensive whitespace reformatting. While the indentation is now more consistent, this creates a large diff that makes it harder to review the actual content changes. Consider whether this reformatting was intentional or if it was an accidental editor setting change. 13. Link updates look correctFiles: The link updates from Verification Needed14. Internal link searchPer AGENTS.md, when moving files, you should update internal links in grep -r "pulumi-insights" content/docs content/product --include="*.md" --include="*.html"to ensure all references have been updated. 15. Image files verificationThe diff shows several new image files added under
Positive Notes✅ Aliases are properly configured in the frontmatter Action Items
Mention @claude if you'd like me to help fix these issues or conduct additional reviews. |
|
Your site preview for commit 1b251f3 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16408-1b251f32.s3-website.us-west-2.amazonaws.com. |
|
Your site preview for commit ec553d2 is ready! 🎉 http://www-testing-pulumi-docs-origin-pr-16408-ec553d23.s3-website.us-west-2.amazonaws.com. |
|
@kimberleyamackenzie please increase the white space between sections, it is too compressed. Top sections
Also on the key features, there is some odd shading, it should be very mild to make it pop. @vctrfrnndz can you assist? Quick mock-up for reference:
Pre-built Compliance sectionMake the button primary, so it pops more 
Governance Lifecycle sectionIncrease the space between title and the bar. Remove shade of the image and increase it (or does the image have empty space that is making it that size?) Quick Mockup below: |
@scottmparker Can you clarify exactly where you want the CTAs and which CTAs I should remove? The current CTAs are all directly from your doc. |
@scottmparker As well, please let me know where this should be "near hero" - in the body? A secondary subtitle? |
|
@vctrfrnndz Can you help with updating the screenshot assets as @SaraDPH suggests, and decrease the white space around the diagram asset? Thank you!! |
|
@kimberleyamackenzie I deleted my comment and will withdraw the requests for now. Please disregard, and sorry for the confusion. |
|
@kimberleyamackenzie Updated diagram asset without spacing: 
|
Fixes: https://github.com/pulumi/marketing/issues/1532
As of 4pm EST on 10/28 still need: