fix provider type for git based plugins #761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgummerer
force-pushed
the
tg/fix-provider-type
branch
from
9641ffa to
f71683d
Compare
tgummerer
force-pushed
the
tg/fix-provider-type
branch
2 times, most recently
from
d27817d to
7b87f22
Compare
tgummerer
added a commit
that referenced
this pull request
Mar 24, 2025
We install some (very) outdated toolchains for the build. The old nodeJS version for example makes `pulumi package add` in #761 not work properly. Update all of these to the latest supported releases.
tgummerer
added a commit
that referenced
this pull request
Mar 24, 2025
We install some (very) outdated toolchains for the build. The old nodeJS version for example makes `pulumi package add` in #761 not work properly. Update all of these to the latest supported releases.
#734 made it so that packages are loaded correctly from disk, but at the same time it also used that name internally, making the provider type look strange (see also pulumi/pulumi#18877). This fixes that (with the help of the pulumi/pulumi changes in pulumi/pulumi#18951), and also adds a regression test, both for the issue fixed in #734, and for the new issue found. Note that #734 is reverted here, as it is no longer needed with the new way we're loading plugins, taking the download url into account correctly.
tgummerer
force-pushed
the
tg/fix-provider-type
branch
from
7b87f22 to
077b47a
Compare
|
This PR has been shipped in release v1.15.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#734 made it so that packages are loaded correctly from disk, but at the same time it also used that name internally, making the provider type look strange (see also pulumi/pulumi#18877).
This fixes that (with the help of the pulumi/pulumi changes in pulumi/pulumi#18951), and also adds a regression test, both for the issue fixed in
#734, and for the new issue found. Note that #734 is reverted here, as it is no longer needed with the new way we're loading plugins, taking the download url into account correctly.
Depends on pulumi/pulumi#18951
Fixes pulumi/pulumi#18877
Fixes #737