Skip to content

Refactor services for testability and clean up obsolete tests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
punkouter26 wants to merge 1 commit into from
Closed

Refactor services for testability and clean up obsolete tests #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"sdk": {
"version": "10.0.102",
"version": "10.0.100",
"rollForward": "latestPatch",
"allowPrerelease": false
}
Expand Down
9 changes: 8 additions & 1 deletion src/PoVicTranslate.Web/Services/TranslationService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ Maintain the sentiment and intent of the original text.
public TranslationService(
IOptions<ApiSettings> apiSettings,
TelemetryClient telemetryClient,
ILogger<TranslationService> logger)
ILogger<TranslationService> logger,
Comment on lines 32 to +33
Copy link

@codereviewbot-ai codereviewbot-ai bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potential NullReferenceException:
The constructor does not validate telemetryClient and logger for null. If either is not provided, subsequent usage will result in a runtime exception.

Recommended solution:
Add explicit null checks for these dependencies:

ArgumentNullException.ThrowIfNull(telemetryClient);
ArgumentNullException.ThrowIfNull(logger);

ChatClient? chatClient = null)
{
ArgumentNullException.ThrowIfNull(apiSettings);
_telemetryClient = telemetryClient;
Expand All @@ -39,6 +40,12 @@ public TranslationService(
var settings = apiSettings.Value;
_deploymentName = settings.AzureOpenAIDeploymentName;

if (chatClient != null)
{
_chatClient = chatClient;
return;
}

if (string.IsNullOrWhiteSpace(settings.AzureOpenAIApiKey) ||
string.IsNullOrWhiteSpace(settings.AzureOpenAIEndpoint) ||
string.IsNullOrWhiteSpace(settings.AzureOpenAIDeploymentName))
Comment on lines 41 to 51
Copy link

@codereviewbot-ai codereviewbot-ai bot Jan 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent Configuration Validation:
The validation of Azure OpenAI settings (lines 49-51) is only performed if chatClient is null. However, _deploymentName is always set from settings.AzureOpenAIDeploymentName (line 41), even when chatClient is provided. If this value is null or whitespace, it could cause runtime errors later.

Recommended solution:
Validate settings.AzureOpenAIDeploymentName for null or whitespace regardless of whether chatClient is provided.

Expand Down
74 changes: 0 additions & 74 deletions tests/Po.VicTranslate.UnitTests/Controllers/LyricsControllerTests.cs
View file
Open in desktop

This file was deleted.

60 changes: 0 additions & 60 deletions tests/Po.VicTranslate.UnitTests/Controllers/TranslationControllerTests.cs
View file
Open in desktop

This file was deleted.

221 changes: 0 additions & 221 deletions tests/Po.VicTranslate.UnitTests/Middleware/ApiResponseTimeMiddlewareTests.cs
View file
Open in desktop

This file was deleted.

Loading
Loading