Handle additional edge cases in puppet.gemspec #9508
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, running `gem build puppet.gemspec` on windows included the windows-specific runtime dependencies in the "ruby" puppet-<version>.gem, because of the `Gem.win_platform?` condition. Now add the runtime dependencies if we're running on that platform via bundler. or if we're building a gem for that platform. In the latter case, it doesn't matter which platform we're running on. This also relaxes the darwin and mingw platforms, to future proof against other variations of darwin and mingw ucrt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, running
gem build puppet.gemspecon windows included the windows-specific runtime dependencies in the "ruby" puppet-.gem, because of theGem.win_platform?condition.Now add the runtime dependencies if we're running on that platform via bundler. or if we're building a gem for that platform. In the latter case, it doesn't matter which platform we're running on.
This also relaxes the darwin and mingw platforms, to future proof against other variations of darwin and mingw ucrt.
Follow up to #9505