Remove purescript-str module #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file is another legacy from Haskell-mode. It contains no autoloaded or interactive (i.e. ones somebody could bind to a hotkey) functions, and the module isn't used anywhere in the code. Some of the functions are specific to Haskell — for example, `purescript-str-trim` mentions some "PureScript Report", which actually refers to Haskell report (when the mode was imported from Haskell, code was batch-renamed from haskell to purescript). So there's no point to prefer purescript-str-trim to plain string-trim. Thus, let's just remove the module from the codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This file is another legacy from Haskell-mode. It contains no autoloaded or interactive (i.e. ones somebody could bind to a hotkey) functions, and the module isn't used anywhere in the code. Some of the functions are specific to Haskell — for example,
purescript-str-trimmentions some "PureScript Report", which actually refers to Haskell report (when the mode was imported from Haskell, code was batch-renamed from haskell to purescript). So there's no point to prefer purescript-str-trim to plain string-trim.Thus, let's just remove the module from the codebase.