Skip to content

Update to PureScript v0.15.0 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 22, 2022
Merged

Update to PureScript v0.15.0 #16

merged 14 commits into from
Mar 22, 2022

Conversation

sigma-andex
Copy link
Contributor

Description of the change

Backlinking to purescript/purescript#4244

Migrates FFI to ES modules

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • Linked any existing issues or proposals that this pull request should close
  • Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@sigma-andex
Copy link
Contributor Author

🏓 @JordanMartinez

thomashoneyman
thomashoneyman reviewed Mar 22, 2022
View reviewed changes
@thomashoneyman
Copy link
Contributor

@sigma-andex Now that there are tests, do you mind adding a test script to run them in the package.json?

@thomashoneyman
Copy link
Contributor

Also, looks like we've got a linting error.

@thomashoneyman
Copy link
Contributor

Whoops, one more thing — can you add this to the CHANGELOG?

JordanMartinez
JordanMartinez suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, just need the changelog.

JordanMartinez
JordanMartinez reviewed Mar 22, 2022
View reviewed changes
bower.json
@@ -12,6 +12,7 @@
"url": "https://github.com/purescript-node/purescript-node-url.git"
},
"dependencies": {
"purescript-nullable": "^5.0.0"
"purescript-nullable": "main",
"purescript-assert": "master"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a devDependency?

JordanMartinez
JordanMartinez suggested changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@JordanMartinez JordanMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'assert' should be a dev dependency in bower.json

@thomashoneyman thomashoneyman merged commit a78ad29 into purescript-node:master Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JordanMartinez JordanMartinez JordanMartinez requested changes

@thomashoneyman thomashoneyman thomashoneyman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sigma-andex @thomashoneyman @JordanMartinez @nwolverson