Skip to content

fix (searchparams): getName should be get #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix (searchparams): getName should be get #24

wants to merge 1 commit into from
+23 −13

Conversation

alphashuro
Copy link

@alphashuro alphashuro commented Oct 12, 2025 •
edited
Loading

getName does not exist in URLSearchParams's API, and the definition here was throwing an error because of this.

It should actually be get.

I checked all node versions prior to verify that it has indeed always been get

Checklist:

  • Added the change to the changelog's "Unreleased" section with a reference to this PR (e.g. "- Made a change (#0000)")
  • [-] Linked any existing issues or proposals that this pull request should close
  • [-] Updated or added relevant documentation
  • Added a test for the contribution (if applicable)

@alphashuro
fix (searchparams): getName should be get
a2a6d7a 
`getName` does not exist in `URLSearchParams`'s API, and the definition
here was throwing an error because of this.

It should actually be `get`.

I checked all node versions prior to verify that it has indeed always
been `get`
@alphashuro alphashuro marked this pull request as ready for review October 12, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@alphashuro