Skip to content

RegexFlags as newtype #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

Fresheyeball
Copy link
Contributor

No description provided.

@paf31
Copy link
Contributor

paf31 commented Feb 19, 2015

The code looks nice, but I think this is only useful if we provide flags with individual options turned on, so that we can say, e.g.

flags = global <> sticky <> multiline

or

flags1 = flags && (not global)

@paf31
Copy link
Contributor

paf31 commented Feb 19, 2015

Also, could you please add markdown comments to your new exported functions?

@paf31
Copy link
Contributor

paf31 commented Feb 19, 2015

Also, I think the monoid dependency is a little unfortunate. Given the flags I mentioned above, I think Semigroup is probably enough, so can we remove it?

@Fresheyeball
Copy link
Contributor Author

Oh sure.

@garyb
Copy link
Member

garyb commented Oct 7, 2016

Thanks for working on this, sorry it never went in! Nearly 2 years later we finally got there: #67

@garyb garyb closed this Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants