Rewrote null check to use mempty #68
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paf31
reviewed
Oct 8, 2016
| @@ -72,7 +73,7 @@ foreign import _toChar :: (forall a. a -> Maybe a) | |||
|
|
|||
| -- | Returns `true` if the given string is empty. | |||
| null :: String -> Boolean | |||
| null s = length s == zero | |||
| null = eq mempty | |||
There was a problem hiding this comment.
Might as well use "" here and avoid the dictionary lookup.
There was a problem hiding this comment.
I knew there must've been a reason why mempty isn't being used here. Is a JSON lookup amortized O(1)?
|
I'm actually baffled as to why it was implemented the way it was! The length approach is how it'd have to be implemented in Haskell (due to It might be better to implement this without point-free though, as string equality can be inlined if it's fully applied: |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.