Skip to content

Conversation

@AdamRJensen
Copy link
Member

@AdamRJensen AdamRJensen commented Dec 5, 2025

  • I am familiar with the contributing guidelines
  • Tests added
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

Adding the longwave downwelling irradiance to the ERA5 variable map. This is not a breaking change as the ERA5 function has not been publicly released yet.

image

@AdamRJensen AdamRJensen added this to the v0.13.2 milestone Dec 5, 2025
@AdamRJensen AdamRJensen added the io label Dec 5, 2025
@echedey-ls
Copy link
Contributor

Should tests be updated anywhere?

Copy link
Member

@kandersolar kandersolar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

xref #2420 and #2573

strd is already in the UNITS dict, so I think this is good to go. No need for additional tests IMHO.

@kandersolar kandersolar added the remote-data triggers --remote-data pytests label Dec 9, 2025
@kandersolar kandersolar merged commit 47fde77 into pvlib:main Dec 9, 2025
38 checks passed
@AdamRJensen AdamRJensen deleted the era5-longwave-map branch December 10, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

io remote-data triggers --remote-data pytests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants