Creating augmented suggester #54
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Grace Sng <[email protected]>
…sponding utils. Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
Signed-off-by: Grace Sng <[email protected]>
amit-sharma
requested changes
Jun 2, 2025
There was a problem hiding this comment.
thanks for the PR @grace-sng7 I've shared a few inline comments.
I also notice that the build is failing. I'm working on a fix and will update this PR.
| { | ||
| "cell_type": "code", | ||
| "source": [ | ||
| "from pywhyllm.suggesters.augmented_model_suggester import AugmentedModelSuggester\n", |
There was a problem hiding this comment.
The notebook makes sense.
Can you add some description/text to the notebook so that readers can understand:
- Motivation: we are introducing this retrieval augmented suggester. It currently works on a specific cause pairs dataset.
- How it works: we fetch the pairs from that dataset.
- some documentation on the actual function call: can say users can give any two variable names, and also tell them what would happen if the pair was not found in the database.
|
|
||
|
|
||
| class AugmentedModelSuggester(SimpleModelSuggester): | ||
| def __init__(self, llm, file_path: str = 'data/causenet-precision.jsonl.bz2'): |
There was a problem hiding this comment.
needs docstrings for each method, so that future editors would be able to understand the code easily.
… dependencies. Signed-off-by: Grace Sng <[email protected]>
|
Hi Dr. Sharma, thanks for the comments. I've added a few updates to the PR. |
amit-sharma
reviewed
Jun 9, 2025
There was a problem hiding this comment.
thanks @grace-sng7 I just have one comment for the notebook.
Signed-off-by: Grace Sng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.