Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature dependent OCP #4907

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

ksudhir111
Copy link

Description

Include temperature dependent OCP.
Have 1D thermal model

Fixes # (issue)

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #)

Important checks:

Please confirm the following before marking the PR as ready for review:

  • No style issues: nox -s pre-commit
  • All tests pass: nox -s tests
  • The documentation builds: nox -s doctests
  • Code is commented for hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@ksudhir111 ksudhir111 requested a review from a team as a code owner March 10, 2025 19:33
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 253 lines in your changes missing coverage. Please review.

Project coverage is 97.66%. Comparing base (f3e9c83) to head (6315992).
Report is 42 commits behind head on develop.

Files with missing lines Patch % Lines
...s/submodels/thermal/Workshop_HW_Thermal_level2_.py 0.00% 166 Missing ⚠️
src/pybamm/experiment/Sudhir_OCP.py 0.00% 30 Missing ⚠️
src/pybamm/experiment/plot_cylinder.py 0.00% 30 Missing ⚠️
...erface/open_circuit_potential/RK_Polynomial_OCP.py 0.00% 27 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4907      +/-   ##
===========================================
- Coverage    98.70%   97.66%   -1.04%     
===========================================
  Files          303      308       +5     
  Lines        23312    23762     +450     
===========================================
+ Hits         23009    23207     +198     
- Misses         303      555     +252     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant