-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Model Entry Points #23
Conversation
Nice to see this progressing! Good to prototype this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slightly nitpicky, but since the API is being merged into one, could we test the model entry points and the parameter sets entry points in the same file?
Co-authored-by: Agriya Khetarpal <[email protected]>
I think this looks good to me and we have two approvals too, so I propose that we merge this so that we can start moving these files to the template. It's likely we'll revisit this code many times anyway, so once we are done, we can follow @valentinsulzer's suggestion in #23 (comment) to add the same things to the PyBaMM repository |
Model Entry Points
to create Model objects within the template and initialise them through entry points.SPM
model which can be initialised through the model entry points.models("modelname/authorname")
is added.Example -
To load the
SPM
model, after installing thepybamm_cookiecutter
project, it can be accessed by calling,pybamm_cookiecutter.Model("SPM")
. This would return an initialised model object of theSPM
model.