Added basic setuptools config in template and tests for build-backends
#37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santacodes
requested review from
brosaplanella,
Saransh-cpp,
agriyakhetarpal and
arjxn-py
16 tasks
Saransh-cpp
requested changes
Aug 3, 2024
There was a problem hiding this comment.
Thanks, @santacodes! I agree with running the pipelines in parallel. Also, with setuptools, we need to handle package file inclusion/exclusion with an extra MANIFEST.in file, could you add it to the template? And the good thing with setuptools-with-scm is that it will make the very MANIFEST.in file I suggest redundant, so we won't need to configure it too much.
Saransh-cpp
requested changes
Aug 5, 2024
agriyakhetarpal
approved these changes
Aug 6, 2024
Saransh-cpp
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Thanks, @santacodes! One minor comment and then feel free to merge
Co-authored-by: Saransh Chopra <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additions
setuptoolsbuild-backend inpyproject.tomlalong withsetuptools-scm(version control system for setuptools).Sub-task #26