chore(cmake): Add an author warning that auto-calculated PYTHON_MODULE_EXTENSION may not respect SETUPTOOLS_EXT_SUFFIX during cross-compilation
#5495
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…LE_EXTENSION` may not respect `SETUPTOOLS_EXT_SUFFIX` during cross-compilation
XuehaiPan
force-pushed
the
cross-compiling-ext
branch
from
4ee9aa0 to
06039bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During cross-compilation, the variable
PYTHON_MODULE_EXTENSIONis calculated via the host Python interpreter rather than the target Python. For example, the build host is x64 Python and the target is ARM64, the calculatedPYTHON_MODULE_EXTENSIONwill be.cpXY-win_amd64.pxdrather than.cpXY-win_arm64.pxd. See also:This PR adds an author warning to prompt the developer to set
PYTHON_MODULE_EXTENSIONmanually during cross-compilation.Maybe related:
Suggested changelog entry: