Skip to content

Experiment: Undo PR #5718 production code changes only, keep added test. #5724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented Jun 13, 2025

Description

Experiment: Does the test added under PR #5718 fail anywhere without the production code changes?

Suggested changelog entry:

  • Placeholder.

@rwgk
Copy link
Collaborator Author

rwgk commented Jun 13, 2025

@henryiii What's the trick to run the tests on all platforms?

@henryiii
Copy link
Collaborator

Take it out of draft.

@rwgk rwgk marked this pull request as ready for review June 13, 2025 18:18
@henryiii
Copy link
Collaborator

LINK : fatal error LNK1104: cannot open file 'python313t.lib' is unrelated, it's a bug in Python 3.13.4.

@rwgk
Copy link
Collaborator Author

rwgk commented Jun 13, 2025

@Rosdf Could you please help working on the new test, so that it fails without the production code changes?

The only one I'd worry about is:

    v_h.value_ptr() = const_cast<void *>(static_cast<const void *>(ptr));

FWIW, I would have guessed that the new test does not work without the production code changes. I was a bit surprised when my quick experiment showed that it doesn't.

@rwgk
Copy link
Collaborator Author

rwgk commented Jun 13, 2025

@Rosdf I forgot to add, to keep things simple, could you please open a new PR? (I don't think you can push to this one; unless I mess with permissions somehow.)

@Rosdf
Copy link
Contributor

Rosdf commented Jun 14, 2025

#5727

@rwgk rwgk closed this Jun 14, 2025
@rwgk rwgk deleted the const_only_smart_ptr_follow_on branch June 14, 2025 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants