Appease MSVC Warning C4866: compiler may not enforce left-to-right evaluation order

[XuehaiPan]

Description

This is a regression after #5948

---

Piggy-backed commit f16de66:

Switch typos pre-commit hook to a mirror repo (adhtruong/mirrors-typos) to fix pre-commit autoupdate selecting the mutable v1 tag instead of pinned versions. See crate-ci/typos#390

Suggested changelog entry:

• Placeholder.

[Skylion007]

Weird warning, but makes sense.

[rwgk]

I added a couple trivial commits.

Will merge after I see that the CI has finished.

[rwgk]

Hm, I don't remember seeing this failure (EDIT: it was resolved by a rerun):

CI / 🐍 (macos-latest, 3.14t, -DCMAKE_CXX_STANDARD=20) / 🧪 (pull_request)

_____________________________ test_async_callbacks _____________________________

    @pytest.mark.skipif(sys.platform.startswith("emscripten"), reason="Requires threads")
    def test_async_callbacks():
        # serves as state for async callback
        class Item:
            def __init__(self, value):
                self.value = value
    
        res = []
    
        # generate stateful lambda that will store result in `res`
        def gen_f():
            s = Item(3)
            return lambda j: res.append(s.value + j)
    
        # do some work async
        work = [1, 2, 3, 4]
        m.test_async_callback(gen_f(), work)
        # wait until work is done
        from time import sleep
    
        sleep(0.5)
>       assert sum(res) == sum(x + 3 for x in work)
E       assert 18 == 22
E        +  where 18 = sum([5, 7, 6])
E        +  and   22 = sum(<generator object test_async_callbacks.<locals>.<genexpr> at 0x4d311ace610>)

Item       = <class 'test_callbacks.test_async_callbacks.<locals>.Item'>
gen_f      = <function test_async_callbacks.<locals>.gen_f at 0x4d31217a2d0>
res        = [5, 7, 6, 4]
sleep      = <built-in function sleep>
work       = [1, 2, 3, 4]

../../tests/test_callbacks.py:186: AssertionError

[XuehaiPan]

The warning still exists. The problem may be that the order of key casting and assignment is not well-defined.

• https://github.com/metaopt/optree/actions/runs/20780977939/job/59757010249?pr=245#step:15:669

  C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-tsdbyp__\overlay\Lib\site-packages\pybind11\include\pybind11\pybind11.h(1087,1): error C2220: the following warning is treated as an error [C:\Users\runneradmin\AppData\Local\Temp\tmph2yqzrcl.build-temp\Release\src\_C.vcxproj]
  C:\Users\runneradmin\AppData\Local\Temp\pip-build-env-tsdbyp__\overlay\Lib\site-packages\pybind11\include\pybind11\pybind11.h(1087,1): warning C4866: compiler may not enforce left-to-right evaluation order for call to 'pybind11::detail::object_api<pybind11::handle>::operator[]' [C:\Users\runneradmin\AppData\Local\Temp\tmph2yqzrcl.build-temp\Release\src\_C.vcxproj]

[rwgk]

Do you have a way to test locally first?

[XuehaiPan]

Do you have a way to test locally first?

Yes, working on it.