Skip to content

Remove -Wno-undefined-inline #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

bricknerb
Copy link

See pybind/pybind11#5664 for context.

@bricknerb
Copy link
Author

What should be the next step here?

@jiawen
Copy link
Collaborator

jiawen commented May 30, 2025

Sorry I'm a busy slammed with my day job at the moment.

I haven't fully grokked the linked discussion yet. But it looks like this change may break compatibility with users on older versions of Pybind11? If so we may need a guard. I'll take a look in a few days when I find cycles.

@henryiii
Copy link

henryiii commented Jun 3, 2025

You really should never be silencing this warning. It shows some of error in your code if an inline is not defined. It does not mean what @bricknerb thinks it means, though (see the linked issue). If you see this warning, the code should also not link. Which I think makes it even more important to remove. If something breaks, please report it as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants